Fill level change api #8
Open
+1,885
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulaScharf
requested changes
Dec 19, 2024
| @@ -53,7 +57,7 @@ initializeMQTT(globalEventEmitter); | |||
|
|
|||
| // Middleware | |||
| app.use(bodyParser.json()); | |||
There was a problem hiding this comment.
with the new middleware, that you added, we dont need this line anymore, right? How about moving line 25 and 26 to here and removing the bodyparser.json?
| if (!user.projects.includes(updatedProject._id)) { | ||
| user.projects.push(updatedProject._id); | ||
| if (!user?.projects.includes(updatedProject._id ) && user) { | ||
| console.log("users",user) |
|
|
||
| if (projectQuery) { | ||
| // Check if the projectQuery is a valid ObjectId | ||
| if (mongoose.Types.ObjectId.isValid(projectQuery)) { | ||
| // console.log("Querying trashbins by ObjectId:", projectQuery); |
| trashbins = await Trashbin.find({ project: projectQuery }) | ||
| .populate('assignee') | ||
| .populate('project'); | ||
| } else { | ||
| //console.log("Querying trashbins by project identifier:", projectQuery); |
| if (project) { | ||
| trashbins = await Trashbin.find({ project: project._id }) | ||
| .populate('assignee') | ||
| .populate('project'); | ||
| // console.log("Fetched trashbins:", trashbins); |
| @@ -1,11 +1,13 @@ | |||
| import { generateUniqueTrashbinIdentifier } from '../service/trashbin'; | |||
| import { Project } from '../models/project'; | |||
| import { Trashbin } from '../models/trashbin'; | |||
| import { History } from '../models/history'; | |||
| import { Types } from 'mongoose'; | |||
There was a problem hiding this comment.
if you check for example line 151 you can see, that they were already referencing mongoose.Types. So I would propose to either remove this import and do line 411 with "mongoose.Types" or change the other references to just "Types" and removing the import in line 7.
Whichever you prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.